Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with HTTP Client and Proxy environment variables #320

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Fix regression with HTTP Client and Proxy environment variables #320

merged 1 commit into from
Nov 6, 2024

Conversation

lionelfleury
Copy link
Contributor

Make sure to add Proxy config in Transport.

See https://pkg.go.dev/net/http#DefaultTransport for reference

Fixes #319

DrJosh9000
DrJosh9000 approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@DrJosh9000 DrJosh9000 merged commit be56dce into buildkite:master Nov 6, 2024
1 check passed
@DrJosh9000 DrJosh9000 mentioned this pull request Dec 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DrJosh9000 DrJosh9000 DrJosh9000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Regression in the 5.9.6 version
2 participants
@lionelfleury @DrJosh9000