Ensure all string slice args have whitespace cleaned off of each element #3021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to use:
buildkite-agent oidc request-token --claim 'this, that, the-other'
where previously, even if `that` and `the-other` were allowed optional claims, they'd be rejected, as they'd be sent to buildkite with their preceeding whitespace
sj26
approved these changes
Oct 2, 2024
DrJosh9000
reviewed
Oct 2, 2024
cliconfig/loader.go
Outdated
| @@ -225,7 +225,11 @@ func (l Loader) setFieldValueFromCLI(fieldName string, cliName string) error { | |||
| case reflect.String: | |||
| value = configFileValue | |||
| case reflect.Slice: | |||
| value = strings.Split(configFileValue, ",") | |||
| valueSlice := strings.Split(configFileValue, ",") | |||
There was a problem hiding this comment.
Good move, it seems very unlikely that any string list will be dependent on whitespace.
moskyb
force-pushed
the
strip-whitespace-on-optional-claims
branch
from
3338f3d
to
fe814e2
Compare
|
@DrJosh9000 i've updated this so that it's the i would love to have a couple of days free to unwind |
moskyb
changed the title
This was referenced Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to use:
where previously, even if
thatandthe-otherwere allowed optional claims, they'd be rejected, as they'd be sent to buildkite with their preceeding whitespaceTesting
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)