Pass cancel grace period to bootstrap #2910
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
buildkite-agent bootstrap
forked frombuildkite-agent start
needs both cancel-grace-period and signal-grace-period.Context
In #2899 the cancel grace period was added as a flag and env var read by the bootstrap subcommand, but I forgot to set it from the job runner.
Changes
BUILDKITE_SIGNAL_GRACE_PERIOD_SECONDS
fmt.Sprintf("%d", ...)
withstrconv.Itoa(...)
(does the same thing, but it doesn't need thefmt
package to parse a format string).Note: the two env vars are different due to historical reasons. See https://github.com/buildkite/agent/blob/main/clicommand/cancel_signal.go
Testing
go test ./...
). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...
)