Log in to buildkite packages right before pushing images #2892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we
docker loginto the buildkite packages container registry in the same place as all the other docker logins, in.buildkite/steps/publish_docker_images.sh. However, because this docker login is done using an OIDC token, it's timed, and only lasts five minutes.If pushing the docker images to registries before BK packages takes longer than five minutes, the push to BK packages will fail, as the token will expire - see here.
This PR updates the docker push process so that we log in to buildkite packages as close as possible to push-time.