Don't try to early-set env vars #2852
Conversation
After some testing, I discovered that the env vars can't be set early enough to affect the bootstrap config
DrJosh9000
force-pushed
the
ps-72-k8s-env-var-conveyor
branch
from
f9cdea8
to
2c938c0
Compare
| // To think about: how to obtain the env vars early enough to set | ||
| // them in ExecutorConfig (because of how urfave/cli works, it | ||
| // must happen before App.Run, which is before the program even knows | ||
| // which subcommand is running). |
There was a problem hiding this comment.
Just for my knowledges, what environment variables were we trying to set "early"?
For our original goal of BUILDKITE_AGEND_ID, does this setup work?
There was a problem hiding this comment.
Anything that normally configures the bootstrap subcommand, but especially the required flags/vars: BUILDKITE_JOB_ID, BUILDKITE_REPO, etc. I would have expected the command container to use these without having to set the env vars for them at schedule time. But that didn't work.
For the original goal of agent env vars that aren't known when the pod is scheduled, yes, this should still work. Commands, plugins etc would be run with the e.shell.Env, but for completeness this PR still inserts them into the current process env (os.Setenv).
Description
After some testing, I discovered that the env vars can't be set early enough to affect the bootstrap config, so this moves back to doing most of the socket setup in executor.go
Changes
Testing
go test ./...). Buildkite employees may check this if the pipeline has run automatically.go fmt ./...)