Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish Buildkite Packages without Docker #2830

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

sj26
Copy link
Member

@sj26 sj26 commented Jun 12, 2024

Following on from #2824 and #2824, it looks like the deploytools image is only available when authenticated to ECR:

image

I started by copy/pasting the auth gear from the other steps which use deploytools .. but then realised all these steps need are bash, buildkite-agent, and curl .. and those are all available on the host. So just remove all the docker plugin stuff and let it run on the host.

@sj26 sj26 requested review from a team June 12, 2024 06:39
@sj26 sj26 self-assigned this Jun 12, 2024
Copy link
Contributor

@DrJosh9000 DrJosh9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦖

sj26 added 2 commits June 12, 2024 16:43
We only need the buildkite-agent and curl, and both should be on the
host machine!
@sj26 sj26 force-pushed the publish-buildkite-packages-ecr-login branch from 601c156 to c654c98 Compare June 12, 2024 06:43
@sj26
Copy link
Member Author

sj26 commented Jun 12, 2024

(rebased without changes because GitHub wanted it updated)

@sj26 sj26 enabled auto-merge June 12, 2024 06:43
@sj26 sj26 merged commit e9e525e into main Jun 12, 2024
1 check passed
@sj26 sj26 deleted the publish-buildkite-packages-ecr-login branch June 12, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants