fix(a11y): fix card violations #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
affects: @buildit/gravity-ui-nunjucks, @buildit/gravity-ui-web Fix aria-labelledby error in svg images ISSUES CLOSED: #375
james-nash
approved these changes
Jan 8, 2020
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #375
Description
Fix accessibility violations regarding to the
card-basecomponent. This component is using aninlineSVGelement to show the SVG symboldecorative-arrow-rightwhich by default doesn't have a title to be referenced. This was causing an ARIA error since there was mismatch between thearia-labelledbyand the no existent title of that particular SVG symbol.NOTE: Other solution could have been to add a
<title>to the SVG symboldecorative-arrow-rightbut this title can change depending on the context where it is being used.Also this PR fixes a typo in the README file.