-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: adds optional classes for page header and footer
affects: @buildit/gravity-ui-nunjucks, @buildit/gravity-ui-web So far Gravity has mandated that page headers and footers had to be *direct* descendents of the \`<body>\` element. Unfortunately, this doesn't play nice with frameworks like React, which recommend having another wrapper element around your page structure. To ease compatibiliy in such cases, this change adds _optional_ component class names that can be used when the page header and footer cannot be direct descendents of the \`<body>\` element. ISSUES CLOSED: #280
- Loading branch information
James Nash
committed
Jul 19, 2019
1 parent
c545c24
commit e481709
Showing
4 changed files
with
18 additions
and
10 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
...gravity-ui-web/src/sass/05-components/03-organisms/00-page-structure/_01-page-footer.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters