fix(hero): makes container overlap banner

affects: @buildit/gravity-ui-web
buildit · May 21, 2019 · aef22c2 · aef22c2
1 parent 0bbddb1
commit aef22c2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/packages/gravity-ui-web/package-lock.json b/packages/gravity-ui-web/package-lock.json
diff --git a/packages/gravity-ui-web/src/sass/05-components/03-organisms/_hero.scss b/packages/gravity-ui-web/src/sass/05-components/03-organisms/_hero.scss
@@ -9,11 +9,6 @@
     object-position: center;
   }
 
-  .grav-o-container {
-    position: relative;
-    margin-top: 0;
-  }
-
   .grav-c-hero__container {
     @include grav-color-grp-a-apply('background-color', 'neutral', false);
 
@@ -30,7 +25,8 @@
 
     width: calc(100% - #{$grav-sp-m * 2});
     max-width: $grav-page-content-max-width - ($container-horizontal-max-margin * 2);
-    margin: ($container-vertical-shift * -1) auto 0;
+    position: relative; // Needed to let container DIV overlap banner IMG element
+    margin: (-1 * $container-vertical-shift) auto 0;
     padding: $container-vertical-shift $grav-sp-m $grav-sp-m $grav-sp-m;
 
     > * {