Mention requirements more clearly in README #224
Conversation
|
Opened Homebrew/homebrew-core#95810 |
|
The first paragraph of the "Installation" section mentions this requirement. Do you think we should clarify it? |
|
Yes. I missed it and Homebrew missed it although whoever wrote The Homebrew formula may have simply assumed that whatever git Homebrew is relying on was adequate and didn't need to be an explicit dependency. Minimally, I think it's worth clarifying that it's needed even if you're not pulling from a git repository. |
|
I need to resolve the conflicts created by my other PR getting merged so I'll revisit this I'm going to finish brewing my coffee. |
I've nearly always had git available anywhere I was using Peru but found while setting up a new CI pipeline that Peru calls git via subprocess for caching.
colindean
changed the title
|
Fixed and ready for review. I chose to list the requirements and then call it out again in the pip section in case someone looks it up fast and misses the previous list. |
|
This is ready! |
1 similar comment
|
This is ready! |
|
Thank you! Sorry for dropping the ball on this one. |
I've nearly always had git available anywhere I was using Peru but found while setting up a new CI pipeline that Peru calls git via subprocess for caching.
This dependency is undeclared in the Homebrew formula but is declared in the AUR package. I'll update the Homebrew formula.