Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update units.csv #105 #106

Merged
merged 10 commits into from
Oct 10, 2024
Merged

Update units.csv #105 #106

merged 10 commits into from
Oct 10, 2024

Conversation

atomczak
Copy link
Collaborator

  • replace semicolons with commas
  • change UTF-16LE to UTF-8

@atomczak
Update units.csv #105
827268a 
- replace semicolons with commas
- change UTF-16LE to UTF-8
@atomczak
add two more units
e43f590
@atomczak
improve units and mapping
759b6e7
@atomczak atomczak marked this pull request as ready for review September 26, 2024 11:44
@atomczak atomczak requested a review from Baars-IT September 26, 2024 11:44
Baars-IT
Baars-IT requested changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@Baars-IT Baars-IT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Artur,
It looks like you saved the CSV file as some kind of binary. Make sure it is just a text file!

@atomczak
Copy link
Collaborator Author

atomczak commented Oct 9, 2024

Weird, it is just a CSV file, have a look at the contents: https://github.com/buildingSMART/bSDD/blob/759b6e77cd942d659a53aba5751c13e2aa184be4/DataFiles/units.csv?plain=1
Also loads fine in Excel, however I see odd encoding: Δ°C

@Erik-RN
Copy link
Collaborator

Erik-RN commented Oct 9, 2024

Can you open it in Notepad and then save it? Then it's surely a text file

@Baars-IT
Copy link
Collaborator

Strange why github cannot display it.
I will push PR and run the import.

@Baars-IT Baars-IT merged commit acc8afb into master Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baars-IT Baars-IT Baars-IT requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atomczak @Erik-RN @Baars-IT