Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Data for Test Case 'Complex properties are not supported' #110

Closed
hesrah opened this issue Oct 28, 2022 · 2 comments
Closed

Sample Data for Test Case 'Complex properties are not supported' #110

hesrah opened this issue Oct 28, 2022 · 2 comments
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@hesrah
Copy link

hesrah commented Oct 28, 2022

The sample data (Sample IDS and Sample IFC filse) for this test case is a complex quantity instead of a complex property:
[FAIL] Complex properties are not supported 1/2
dito: [FAIL] Complex properties are not supported 2/2

Is this intended? Sample data should be the same as in the doc?
The sample data are the sample data for the next following test case 'Complex properties are not supported' "2" - which should called 'Complex quanities are not supported'?

@MatthiasWeise
Copy link
Contributor

I would suggest to make a note in the property facet documentation what kind of properties/quantities are in scope (all simple properties?) and what is out of scope (complex properties?).

@CBenghi CBenghi added this to the 1.0 milestone May 31, 2023
@CBenghi CBenghi added documentation Improvements or additions to documentation and removed discuss & decide labels Jun 14, 2023
atomczak added a commit that referenced this issue Nov 7, 2024
@atomczak
Copy link
Contributor

atomczak commented Nov 8, 2024

Good suggestion. Looking at the test cases, we allow simple value, bounded, list, table and enumerated properties, while don't allow complex and reference values. I added a paragraph to the property docs.

@atomczak atomczak closed this as completed Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

4 participants