Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add audit info to viewpoint #292

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Add audit info to viewpoint #292

merged 5 commits into from
Aug 28, 2023

Conversation

jasollien
Copy link
Contributor

No description provided.

@jasollien jasollien linked an issue Sep 13, 2021 that may be closed by this pull request
Proposal: Add audit information on viewpoints #291
Closed
@GeorgDangl GeorgDangl changed the base branch from release_3_0 to master April 17, 2023 09:32
@GeorgDangl
Copy link
Member

Regarding comments: Right now, the API allows to create empty comments when they are referencing a viewpoint via viewpoint_guid: https://github.com/buildingSMART/BCF-API#342-post-comment-service
image

So, previously, comments could either have a comment or a viewpoint_guid (or both). Now, empty comments should be disallowed.

@GeorgDangl GeorgDangl mentioned this pull request Jun 5, 2023
Closed
@GeorgDangl GeorgDangl merged commit c2584b0 into master Aug 28, 2023
@GeorgDangl GeorgDangl deleted the viewpoint-audit branch August 28, 2023 09:36
@GeorgDangl GeorgDangl mentioned this pull request Aug 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgDangl GeorgDangl GeorgDangl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Add audit information on viewpoints
2 participants
@jasollien @GeorgDangl