Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Starlark version of 'http_archive' for Bazel >= 0.20 compatibility #7

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

sgbalogh
Copy link
Contributor

@sgbalogh sgbalogh commented Jan 5, 2019

Hi,

I ran into an issue while trying to build this project using Bazel 0.20.0:

$ bazel build //:remote_client
Starting local Bazel server and connecting to it...
INFO: Invocation ID: d32c4b6a-9707-4801-8bea-4a1c8691ad93
ERROR: Analysis of target '//:remote_client' failed; build aborted: no such package '@googleapis//': The native new_http_archive rule is deprecated. load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") for a drop-in replacement.
Use --incompatible_remove_native_http_archive=false to temporarily continue using the native rule.
INFO: Elapsed time: 6.744s
INFO: 0 processes.
FAILED: Build did NOT complete successfully (8 packages loaded, 23 targets configured)
    Fetching @googleapis; fetching

It appears that the native 'http_archive' functions have been deprecated as of Bazel 0.20. This patch imports the replacements from the Starlark extensions. See: bazelbuild/bazel#6570 for reference.

Making these changes allowed the build to complete.

Thanks!
-S

The native 'http_archive' functions have been deprecated as of Bazel 0.20. This patch imports
the replacements from the Starlark extensions. See: bazelbuild/bazel#6570
@agoulti agoulti merged commit caeeb46 into buildfarm:master Jan 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants