Add download rate metrics for buildfarm:worker #1418
Conversation
| @@ -68,6 +69,9 @@ | |||
|
|
|||
| @Log | |||
| public class ShardWorkerInstance extends AbstractServerInstance { | |||
| private static final Counter ioMetric = | |||
There was a problem hiding this comment.
Blindly copied from ShardInstance :( removed
There was a problem hiding this comment.
Counter's register function appends (registers) metrics to a static instance of the CollectorRegistry.
After I modified the ioMetric variable to be non-static, the unit tests in ShardWorkerInstanceTest began to fail. This is because each test generates a fresh ShardWorkerInstance instance, and with every instance creation, it tries to register the same metrics with the CollectorRegistry again and fails with already register error.
Although buildfarm:worker at runtime only creates single instance of ShardWorkerInstance and even making the ioMetric non-static will work but it is not configured to be singleton. Also ioMetric need to be registered only once not per instance.
There was a problem hiding this comment.
@werkt Can you please merge it.
There was a problem hiding this comment.
Alright. We will need to get rid of the statics overall elsewhere.
Download rate metrics for worker was missing. Added metrics for worker download rate.