Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce log levels to make log files more meaningful #1414

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

80degreeswest
Copy link
Member

@80degreeswest 80degreeswest commented Aug 1, 2023

Currently we log a lot of stuff as info, most of which is trivial. This logging is also mixed with meaningful entries which are necessary for troubleshooting. This PR downgrades most frequent log entries to make the more meaningful entries easier to track.

The expected outcome of this change is to set log level to FINE to produce the same output as prior to this change.

@80degreeswest 80degreeswest requested review from luxe and jacobmou August 1, 2023 13:49
@80degreeswest 80degreeswest requested a review from werkt as a code owner August 1, 2023 13:49
@luxe
Copy link
Contributor

luxe commented Aug 1, 2023

haha, FINE, FINER, FINEST

@80degreeswest 80degreeswest force-pushed the 80degreeswest/reduce_logging branch from 8348e8e to 884b7d3 Compare August 1, 2023 13:56
@80degreeswest 80degreeswest force-pushed the 80degreeswest/reduce_logging branch from 884b7d3 to bb1eb9e Compare August 1, 2023 14:24
@80degreeswest 80degreeswest merged commit 8710642 into main Aug 1, 2023
@80degreeswest 80degreeswest deleted the 80degreeswest/reduce_logging branch November 16, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants