Enable custom latency buckets #1376
Conversation
|
awesome! I'm not sure why the formatter didn't fix the buildifer issue. If you can get that green, we can land. |
Running |
Fixed it. |
| @@ -9,8 +9,9 @@ server: | |||
| actionCacheReadOnly: false | |||
| port: 8980 | |||
| grpcMetrics: | |||
| enabled: false | |||
| provideLatencyHistograms: false | |||
| enabled: true | |||
There was a problem hiding this comment.
any reason to have lines 12:13 and 95:96 be different?
There was a problem hiding this comment.
Nothing specific, I was testing locally and updated to ensure both combination works.
examples/config.yml
Outdated
| provideLatencyHistograms: false | ||
| enabled: true | ||
| provideLatencyHistograms: true | ||
| latencyBuckets: [0.001, 0.005, 0.01, 0.05, 0.075, 0.1, 0.25, 0.5, 1.0, 2.0, 5.0, 10.0] |
There was a problem hiding this comment.
we still get the infinite bucket, right? i also suggest example to include buckets up to 60s, and then 60+ since 60s is default for bazel.
There was a problem hiding this comment.
Updated example config with infinity bucket. Also in the example I have used different latency buckets for server and workers as developers can have different latency bucket for server and worker.
Prometheus provides a default latency bucket, and that may not be helpful all use case. This change provide capability to define custom latency buckets.