proto: handle go proto library deprecation #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is based on #5655 and should only be merged after. |
luluz66
reviewed
Jan 8, 2024
luluz66
approved these changes
Jan 8, 2024
sluongng
force-pushed
the
sluongng/handle-go-proto-library-deprecation
branch
from
06b2765
to
babe1e7
Compare
sluongng
added a commit
that referenced
this pull request
Jan 9, 2024
This is a follow-up for #5662. Turn out our external dependencies also need some proto love ```bash WARNING: /private/var/tmp/_bazel_sluongng/06e573a93bc2d6a9cad4ad41f00b4310/external/com_github_buildbuddy_io_tensorflow_proto/tensorflow_serving/apis/BUILD.bazel:27:17: in go_proto_library rule @@com_github_buildbuddy_io_tensorflow_proto//tensorflow_serving/apis:apis_go_proto: target '@@com_github_buildbuddy_io_tensorflow_proto//tensorflow_serving/apis:apis_go_proto' depends on deprecated target '@@io_bazel_rules_go//proto:go_grpc': Migrate to //proto:go_grpc_v2 compiler (which you'll get automatically if you use the go_grpc_library() rule). ``` Ensure that when Gazelle is run on external dependencies, the proper directive is also applied so that the newer compilers are used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In bazel-contrib/rules_go#3761, rules_go started deprecating away
the usage of https://github.com/golang/protobuf in favor of a combination of
https://github.com/protocolbuffers/protobuf-go and https://github.com/grpc/grpc-go/blob/master/cmd/protoc-gen-go-grpc.
This results in
go_proto_libraryrequiring these 2 new compilers.As an convinience, a
go_grpc_librarymacro was introduced to wrap aroundgo_proto_libraryto ensure that these 2 compilers are set by default.
Effectively, in our
go_proto_librarytargets, switch our usage of the old compiler to the new pair of compilers.We are not using
go_grpc_libraryyet because Gazelle has yet to support it. bazel-contrib/bazel-gazelle#1711Related issues: N/A