Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazelrc: support generate coverage output with lcov and genhtml #3899

Merged
merged 1 commit into from
May 3, 2023

Conversation

sluongng
Copy link
Contributor

@sluongng sluongng commented May 3, 2023

Used this recently to help with writing tests for #3800 and #3861.
Super helpful to identify code branches with missing tests.

Related issues: N/A

Used this recently to help with writing tests for #3800 and #3861.
Super helpful to identify code branches with missing tests.
@@ -149,6 +149,12 @@ test:webdriver-debug --test_env=DISPLAY
# otherwise), and display verbose webdriver output in the terminal.
test:webdriver-debug --test_output=streamed

# Currently only works for go tests
# Coverage outputs could be viewed with `genhtml`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also recently added support in the UI to view this on the test results page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, however I think it's rendering using the wrong version of the source file 🤔
Perhaps it was because I did not push the changes to github just yet?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, if you push the changes to Github it should be able to render correctly

@sluongng sluongng merged commit ecbb56c into master May 3, 2023
@sluongng sluongng deleted the sluongng/go-coverage branch May 3, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants