Tidy up #187
Merged
Tidy up #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
reviewed
Feb 7, 2024
EdSchouten
reviewed
Feb 7, 2024
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
2 times, most recently
from
c2ac931
to
0beee53
Compare
|
Thanks for the comments. Will address them soon. I accidentally pushed section 2 here, which I'd rather review as a stacked pull request (because it needs more review and redesign, thanks for that!). Sorry for the inconvenience here. |
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
from
0beee53
to
45101fe
Compare
EdSchouten
requested changes
Feb 8, 2024
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
from
45101fe
to
1c26964
Compare
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
from
1c26964
to
5590ba4
Compare
added 3 commits
March 8, 2024 15:45
To work with users who prefer a different output in their personal rc file. Using '--nohome_rc' is not good either, if they want to change the output base this query would duplicate a lot of data.
stagnation
force-pushed
the
feature/tidy-up-2024-01
branch
from
5590ba4
to
0fbac2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some small changes to I made during the work to update windows workers.
Keep them as a separate PR to merge them sooner, and reduce the scope of the meaty review of the PR.