Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Targets Exploration View, Problems Tab Updates #53

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Targets Exploration View, Problems Tab Updates #53

merged 4 commits into from
Oct 30, 2024

Conversation

trey-ivy
Copy link
Collaborator

Currently, when you have large builds w/several invocations displayed in a single build view, if the problems tab contains lots of debug data, it can cause the view to hang forever and/or crash the view. The problems view contains helpful data, but it does not necessarily need to be the default tab for an invocation. Adding an 'overview' tab allows us to dynamically load the 'problems' data only when requested (i.e. when the user clicks the tab). This clears up the issue with builds, provides faster loading times, and gives us the ability to key in on other useful data in the overview tab.

invocation overview tab (dynamically hide problems tab for successful builds)
image

problems tab moved to the end and displayed dynamically (spinner while loading)
image

the display issue for remote blobs still remains.

Target exploration and the ability to chart target build time extends the same base functionality found in the /tests route to a /targets route. Since tests are targets, just with more data, we may want to look at consolidating these views at some point as well, but for now, just giving the ability to view the historic trend data for a given target will be useful.

targets exploration view
image

targets pass/fail grid
image

targets details view
image

  • updates schema to add order by functionality to targetpair entity
  • add graphql api methods for getting target data
  • decouple problems data from bazel invocation view data
  • targets and targets/[slug] routes and views
  • targets exploration views and components
  • extend custom schema with target display associated types
  • update golden files for testing

@mortenmj mortenmj merged commit 1bd0b79 into main Oct 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants