Add Profile download button the Invocation page #10
Conversation
|
Wow you fixed CI as well! That is great! Overall this is a very nice addition to the project and thank you for putting this up. It does unfortunately completely break the invocation view on my machine. I did some debugging and the URL that I get for the profile is apparently formed differently than yours. Seems like you're expecting one less slash element in the string. As an example, here is what I see in the URI bytestream://rbe.stackav.io/remote-execution/blobs/b180b5bf760640a36acbcb2a85d431ff050eb1c4d0b75af8978e9683d3b0294a/5374 And it causes the graphql query to return data that the application cannot map to a known type, so that breaks the view and all you see is an empty page with no content for the invocation. Here is what I saw in the graphql query when i was troubleshooting. 
Also I have some feedback on where/how the buildbarn browser URL is provided. I dislike the idea of providing what is essentially frontend configuration information to the backend as a runtime flag. I think this should be supplied as an environment variable to the frontend (you can put it in the .env file). Then just build the URL on the fly on the frontend when you're displaying it to the user no need to prepend the broswerUrl to the item stored in the database. Frankly, you shouldn't have to update the model or extend the schema in any way because this information is already stored in the relatedFiles object. Adding this profile object essentially just duplicates information already stored in the database. Below you can see an example of this. 
I am however impressed that you understood how to update the schema and flow that information all the way through the frontend, and there could be a valid reason for this approach and needing to store this data in the backend, but I would prefer we just leverage the existing relatedFiles object either way. After I updated the code so that it would work (think slice from the back) to grab the size in bytes and the hash correctly for my URL, I ran into an additional issue. My buildbarn browser service is deployed in a production environment and is secured using OIDC. When I actually tried to download the file, I got the following error:
Now I'm okay if initially this doesn't work with auth as long as there is a backlog item to address this. I think if you explore the codebase you may find something already baked in to help with this as well |
If the user passes
-browser-url, a download button is put in the top right corner when viewing an invocation. This links to bb-browser, allowing the profile to be downloaded.TODO: It would be nice if the download button was scaled to the same size as the 'succeeded' and 'time' boxes/labels on the same row. Right now it is subtly larger.