-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance Improvements for Buildbarn deployments K8's (Work in Progress) #82
Draft
Ryang20718
wants to merge
8
commits into
buildbarn:master
Choose a base branch
from
Ryang20718:user/ryang/fuse_kubernetes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Performance Improvements for Buildbarn deployments K8's (Work in Progress) #82
Ryang20718
wants to merge
8
commits into
buildbarn:master
from
Ryang20718:user/ryang/fuse_kubernetes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EdSchouten
reviewed
Feb 15, 2023
name: worker | ||
volumeMounts: | ||
- mountPath: /config/ | ||
name: configs | ||
readOnly: true | ||
- mountPath: /worker | ||
name: worker | ||
- mountPath: /storage-worker-cas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try destroying/recreating that object.
Ryang20718
commented
Feb 15, 2023
Ryang20718
force-pushed
the
user/ryang/fuse_kubernetes
branch
from
February 15, 2023 07:23
b1e44e1
to
b9e21f5
Compare
Ryang20718
force-pushed
the
user/ryang/fuse_kubernetes
branch
from
February 15, 2023 08:27
caca2b1
to
9377925
Compare
Ryang20718
force-pushed
the
user/ryang/fuse_kubernetes
branch
from
February 15, 2023 08:29
9377925
to
7bd1692
Compare
lijunsong
reviewed
Feb 28, 2023
@@ -42,14 +47,16 @@ spec: | |||
image: ghcr.io/catthehacker/ubuntu:act-22.04@sha256:5f9c35c25db1d51a8ddaae5c0ba8d3c163c5e9a4a6cc97acd409ac7eae239448 | |||
name: runner | |||
securityContext: | |||
runAsUser: 65534 | |||
allowPrivilegeEscalation: false | |||
privileged: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think HostToContainer needs privilege.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aids in increasing performance for tasks that have a lot of input actions