Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Move the buildifier check for whitespace last #106

Closed

Conversation

stagnation
Copy link
Collaborator

I always seem to trip this up, and would rather have the feedback that everything else is honky-dorey. And that the error is just a clerical omission, in the presence of well working code.

@moroten
Copy link
Collaborator

moroten commented Nov 16, 2023

I thought you would prefer quick feedback before any slow compilation.

@stagnation
Copy link
Collaborator Author

Yes that too is a good point. I do not have a very strong opinion here, but want to open the discussion. As it stands I already have time for a context switch :/. I guess what I would like most is to have keep-going semantics, and return buildifier as soon as possible, but also report (in time) that everything else works.

@stagnation stagnation closed this Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants