You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When terminating TLS on a reverse proxy in front of script-server, any redirects returned by script-server should use the HTTPS scheme, but the current behavior is that they use HTTP regardless. https://github.com/bugy/script-server/wiki/Reverse-Proxy-setup says to set the X-Scheme header in this scenario, but it is not respected.
Here's a docker-compose.yml to reproduce the issue:
(It's also worth noting that X-Scheme is a nonstandard header. X-Forwarded-Proto is the more de-facto standard and the proto directive of the Forwarded header is an actual standard.)
The text was updated successfully, but these errors were encountered:
dnrce
changed the title
X-headers aren't honored
Redirects to HTTP when behind HTTPS reverse proxy
Mar 6, 2021
Done. I tested it for tornado5 and tornado6, seems to be working.
Now X-Scheme and X-Forwarded-Proto headers are always respected, but no other x-headers
Thanks for the docker compose, was really helpful!
When terminating TLS on a reverse proxy in front of
script-server
, any redirects returned byscript-server
should use the HTTPS scheme, but the current behavior is that they use HTTP regardless. https://github.com/bugy/script-server/wiki/Reverse-Proxy-setup says to set theX-Scheme
header in this scenario, but it is not respected.Here's a
docker-compose.yml
to reproduce the issue:When querying via HTTPS,
script-server
issues a redirect back to HTTP:(It's also worth noting that
X-Scheme
is a nonstandard header.X-Forwarded-Proto
is the more de-facto standard and theproto
directive of theForwarded
header is an actual standard.)The text was updated successfully, but these errors were encountered: