Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show an indicator when a script is loading #281

Closed
antonellocaroli opened this issue Mar 29, 2020 · 11 comments
Closed

Show an indicator when a script is loading #281

antonellocaroli opened this issue Mar 29, 2020 · 11 comments

Comments

@antonellocaroli
Copy link

couldn't you make the description appear right away?
before the scripts in the parameters are queried?
I have some scripts in the parameters that take some time, so a user might think the system is locked, entering a description of this would make it clear to the user to wait for the query of the script...

@bugy
Copy link
Owner

bugy commented Mar 29, 2020 via email

@bugy
Copy link
Owner

bugy commented Mar 29, 2020 via email

@antonellocaroli
Copy link
Author

the progress bar would be great.
but in the history section, I see it's not very visible.

it would be nice to have it either right under the title, or even better on the EXCUTE button.

like the EXCUTE button becomes WAIT...with a progress bar underneath and when finished it becomes EXCUTE.

@bugy bugy changed the title wait... Show an indicator when a script is loading Mar 29, 2020
@bugy bugy added the feature label Mar 29, 2020
bugy added a commit that referenced this issue Apr 25, 2020
@bugy
Copy link
Owner

bugy commented Apr 25, 2020

Done, now script loading will have a progress indicator under header (I also made it for history section)
Also, there will be a loading text and execute button will be disabled.

Could you please check, if it works for you, please?

@bugy bugy added the resolved label Apr 25, 2020
@bugy bugy added this to the 1.16.0 milestone Apr 25, 2020
@antonellocaroli
Copy link
Author

antonellocaroli commented Apr 25, 2020

@bugy
That's great!!
Thank you!!!!
it works fine!
:)

Loading ....... what a lovely weather today ........ patience is power ......... doing my best .......... I give up :(

maybe just "i give up" comes "too soon." ?

I have long scripts :)

@bugy
Copy link
Owner

bugy commented Apr 25, 2020

Wow, it takes more than 30sec to load the script Oo I hoped nobody would read the last message

@antonellocaroli
Copy link
Author

maybe just "i give up" comes "too soon." ?

I have long scripts :)

@bugy
Copy link
Owner

bugy commented Apr 25, 2020

Well, usually people are fine for waiting 3-5 sec in such services. 30 sec for me sounds already quite a lot
Probably I need to change this message. "I give up" sounds like the loading is finished, but actually it's not

@antonellocaroli
Copy link
Author

I've changed it so far.

Loading ....... I'm still alive ........ some bits got stuck ......... don't leave me .......... waiting :)

@antonellocaroli
Copy link
Author

Still great!!!!
I really like it!!!!

bugy added a commit that referenced this issue Apr 26, 2020
@bugy
Copy link
Owner

bugy commented Apr 26, 2020

@antonellocaroli I changed the last message to "loading time is unknown". So if you want, you can use it and avoid custom changes on your side

antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
@bugy bugy closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants