Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for default values for included parameters #201

Closed
bugy opened this issue Mar 23, 2019 · 5 comments
Closed

Add support for default values for included parameters #201

bugy opened this issue Mar 23, 2019 · 5 comments

Comments

@bugy
Copy link
Owner

bugy commented Mar 23, 2019

If script configuration contains included parameters (from another file), then default values of these parameters are ignored.
Default values should be filled once included parameters are shown for the first time, i.e. if a user puts some value in such a parameter and then switches to another included config and back, the value should remain, as set by the user

@yosefy
Copy link

yosefy commented Apr 17, 2019

waiting for this one patiently :)
we need it in prod
devs 99 % of the time don't need to choose the values, and they don't know the default

thanks

@bugy bugy added this to the 1.14 milestone Apr 19, 2019
@bugy bugy added the resolved label Apr 19, 2019
@bugy
Copy link
Owner Author

bugy commented Apr 19, 2019

Hi @yosefy, I implemented support for default values. Could you check please, if it's working for you in a dev build?

@yosefy
Copy link

yosefy commented Apr 20, 2019

it is working, needed to flush cache

thank you

@bugy
Copy link
Owner Author

bugy commented Apr 21, 2019

Perfect, thanks for confirming!

@bugy
Copy link
Owner Author

bugy commented Apr 21, 2019

By the way, you can download the latest release from releases or use docker. There is no need to clone the whole repo

@bugy bugy closed this as completed Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants