Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-instance for the same script #145

Closed
csphoenix1 opened this issue Dec 6, 2018 · 15 comments
Closed

Multi-instance for the same script #145

csphoenix1 opened this issue Dec 6, 2018 · 15 comments

Comments

@csphoenix1
Copy link
Contributor

Hi !

Before this feature #94, if we wanted to launch a multiple instance of this current script which is running, we have just to open a new tab.
Now, we can't because we going back to the running instance.

Going back to the running instance is really really cool ! But maybe we can add an improvement to allow the run of multiple instances of a same script?
I think it is not easy, but that could be cool too :)

@bugy bugy added the feature label Dec 6, 2018
@bugy
Copy link
Owner

bugy commented Dec 6, 2018

Ye, this is definitely needed, I was waiting for this ticket (if anybody would need such functionality).
The hardest part of this issue is to make it in a user-friendly way. I'll think about it

@csphoenix1
Copy link
Contributor Author

I though about the interface and maybe we can do like the browser (with tabs).

What do you think about it?

clipboard image

@bugy
Copy link
Owner

bugy commented Dec 13, 2018

Hi @csphoenix1, good idea, I had similar idea also :) But I'm thinking about putting the "tabs" to the right of script name, to save some vertical space

@csphoenix1
Copy link
Contributor Author

Hi @bugy, cool :)
About the position, I'm afraid there is a probleme if the script name is long (on my server, I have some script which are a little long ^^).
A tab row is not very very high, maybe 20px? I'm not very good in design but I believe in you, if you think it's better, I'm okey with you :)

@bugy bugy added this to the 1.16.0 milestone Mar 26, 2020
@bugy
Copy link
Owner

bugy commented May 14, 2020

I hope anybody if following this thread :) I'm struggling a little bit with design, so far I came up with some ideas (screenshot attached). Any preferences here? :)
script-server title

@antonellocaroli
Copy link

Hi,

In my system, that wouldn't be a function that would be used much.

But I probably like the last one...

@antonellocaroli
Copy link

or maybe this one

image

@bugy
Copy link
Owner

bugy commented May 15, 2020

Hi @antonellocaroli thanks for the feedback!

@csphoenix1
Copy link
Contributor Author

csphoenix1 commented May 15, 2020

Hi @bugy,

I love have lot information without additionnal click, and I love see the informations easily, so the one for me is a mix between 2 of your purposes.

image

The reasons :

  • We can have the full list and the state of each instances without additionnal clicks : all instance are displayed with their states.
  • We can see very easily the thread on which one we are (underlined, in black and bold), and the other are in grey, and in a smaller size.
  • We can add very fastly (and with few mouse movements) a new instance (just after click on the runner) thanks to the button which is near on the left).

:)

Good job in all cases :)

@bugy
Copy link
Owner

bugy commented May 21, 2020

Done :) Feel free to get latest dev version and test it :)

@csphoenix1
Copy link
Contributor Author

Hi Bugy !

I've just test the multi instance feature and... it's really cool ! Well done !

If i had to say negative things I will say that :

  • I understand that the number of instance available depend of the free space at the right of the script title. If the script name/title is long, the number of instances will decrease (until only one instance available :'( ). A workaround could be let the user have an unlimited instances available by adding rows bellow. If the user need only few instances, all could be in the title row. And if it need more instances, row bellow will appear (it will be bad because it will reduce the size of the console bellow, but it the price to paid if he want more instances :) ). What do you think about it?

  • When an instance is finished, if we move to another script and going back to the first one, the instance will autoclose. So, for example, if I want to compare the output of different instances launched previsouly, I can't because the instances were autoclosed. Maybe let the user to close himself the instances it has open ? Or add a global configuration variable to let the user the mode he want "autoclose the instance" or not ?

Despite of these two things, all is really cool and seem to work very well.

Very good job sir :)

@csphoenix1
Copy link
Contributor Author

Hi Bugy,

I'm continuing to test the multi instance feature and I discover a problem.
When I add a new instance by clicking the + button, the default value of a variable (specified is the json script configuration file) is not present for the new instance. But is present for the default instance.
I think it's not normal.
It's a minor problem in all cases :)

antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
antonellocaroli pushed a commit to antonellocaroli/script-server that referenced this issue Aug 1, 2020
@bugy
Copy link
Owner

bugy commented Aug 16, 2020

Hi @csphoenix1 thanks for reporting this bug. Unfortunately, I missed your message and noticed this broken behaviour only now :) fixed

@bugy
Copy link
Owner

bugy commented Aug 16, 2020

Regarding your 2 other comments, I created the separate tickets for future:

@bugy
Copy link
Owner

bugy commented Sep 12, 2020

Fixed too aggressive closing of non-viewed tabs or closing active tab on click

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants