Use serial comm functions from golang.org/x/sys/windows #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
golang.org/x/sys v0.19.0 has been released including the serial comm functions, so this is now ready for review. |
|
Closing due to inactivity. |
|
@twpayne I'm sorry for the long delay in replying to PR, unfortunately, I run this project in my free time, so PR may take very long to process. I see the value in the proposed changes, so I'd like to ask if you can reopen the PR, or if I can cheery pick your commits for future changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've opened a CL for golang.org/x/sys to add Windows serial communication functions: https://go-review.googlesource.com/c/sys/+/572295.
If/when this is merged and released, bugst/go-serial can drop its own implementation of these and use golang.org/x/sys/windows.
This PR is currently in draft as the functions are not yet merged or released in golang.org/x/sys/windows. If they make it in then I'll mark this PR as ready.