PHP 8.4 support #672
Merged
PHP 8.4 support #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no clue why PHP 7.2 tests suddenly fail. It feels related to bugsnag/bugsnag-laravel#544 |
|
I tried applying the same fix as in that Laravel PR, but it didn't help |
Cawllec
reviewed
Dec 6, 2024
There was a problem hiding this comment.
I've tested this against our previous versions, and it seems to resolve the 8.4 issues nicely! I've also tested with PHP 5, and can confirm it works there as well.
Could we retarget the merge into next, then I can take care of the changelog and version bumps, and get it released?
tomlongridge
reviewed
Dec 6, 2024
Co-authored-by: Tom Longridge <[email protected]>
Cawllec
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
With the recent release of PHP 8.4, some of the features that were used by the notifier were marked as deprecated and started throwing depreciation warnings. This PR removes both of the depreciation warnings without breaking backwards compatibility.
https://php.watch/versions/8.4/E_STRICT-deprecated
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated
Design
The issue with nullable types was solved by removing type annotations from parameters that default to
null. Type annotations provided in the doc comments above already provide accurate annotations, so LSPs should continue to infer types correctly.The depreciation of
E_STRICTrequired more widespread changes. Due to conditional properties in associative arrays not being supported in <6.0, the list of errors had to be rewritten with an initializer that conditionally adds the value to the array. This also warranted a change in tests that rely onE_STRICT.The added tests for PHP 8.3 and 8.4 required small changes in the unit tests to account for differences in error messages.
Changeset
E_STRICTin PHP 8.4+.Testing
Tested manually and automatically. No new tests were added. Some of the existing tests were extended.