Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Report::getFeatureFlags to allow accessing feature flags in callbacks #653

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Add Report::getFeatureFlags to allow accessing feature flags in callbacks #653

merged 2 commits into from
Oct 19, 2022

Conversation

imjoehaines
Copy link
Contributor

Add Report::getFeatureFlags to allow accessing feature flags in callbacks. This returns a list of FeatureFlag instances (the same class used in addFeatureFlags)

I've changed the return value of FeatureFlagDelegate::toArray to the raw array of feature flags to support this. The Report::toArray now handles formatting the list of feature flags for the Event API

@imjoehaines imjoehaines requested a review from kattrali October 18, 2022 09:50
kattrali
kattrali approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@kattrali kattrali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@imjoehaines imjoehaines merged commit 31b93f4 into next Oct 19, 2022
@imjoehaines imjoehaines deleted the feature-flags-getter branch October 19, 2022 08:14
This was referenced Oct 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattrali kattrali kattrali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjoehaines @kattrali