Add phpstan and fix up types #633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @xPaw, thanks for the PR! This is something I'll be working on soon, so I'm happy to take over and get it merged 🙂 |
|
That's fine by me. I didn't fix the other phpstan issues because they require some actual code changes, which I don't know how Bugsnag wants to handle. |
Merged
|
I'm going to merge this in #637, thanks a lot for the starting point in this PR! I decided to only go as far as level 6 at the moment, as I'd like to enable |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were plenty of incorrect types, I've fixed up most of them.
phpstan still reports various errors which should be fixed, but I'll leave that. If you're not really interested in phpstan, type fixes can be merged without it.