Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/session guzzle client #521

Closed
wants to merge 10 commits into from
Closed

Fix/session guzzle client #521

wants to merge 10 commits into from

Conversation

Cawllec
Copy link
Contributor

@Cawllec Cawllec commented Feb 18, 2019

Goal

Enables using the same GuzzleHttp\Client for all HTTP requests, meaning any custom options set will be applicable across event, session, & build notifications.

Design

  • Adds a public method deliverPayload to the HttpClient
  • Changes SessionTracker to use deliverPayload for session delivery
  • Adds notifyEndpoint to configuration with appropriate getter & setters
  • Deprecate getSessionClient method on Configuration and Client
  • Extracts base_uri/base_url from passed guzzle clients and assigns the value to notifyEndpoint to retain existing behaviour.

Tests

  • Updates existing tests to work with any API changes:
    • Removes reflection into HttpClient when testing default client setup
    • Guzzle client now expects blank headers when delivery build or deploy notifications
  • Adds tests and lines in existing tests referencing new behaviour.
  • Includes updates for tests established in SessionTracker tests #520 , requiring that to be merged first.

@Cawllec Cawllec requested review from snmaynard and a team February 18, 2019 11:43
@bengourley bengourley removed the request for review from a team October 29, 2019 14:55
@Cawllec Cawllec added the on hold label Nov 8, 2019
@xljones xljones added wip There is work in progress and removed on hold labels Apr 30, 2020
@bugsnagbot bugsnagbot added the scheduled Work is starting on this feature/bug label Jun 3, 2020
@imjoehaines imjoehaines mentioned this pull request Jun 4, 2020
15 tasks
@imjoehaines
Copy link
Contributor

Continued in #587

@kattrali kattrali deleted the fix/session-guzzle-client branch November 5, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scheduled Work is starting on this feature/bug wip There is work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants