Automatically retry the Electron performance test #1679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this runs on GH Actions, it's inherently unreliable as we could be given a very over-provisioned VM so the performance is unpredictable Until we can migrate to a more stable platform, we can only retry this test until it passes — there is some value in knowing it will pass when retried, rather than always failing
imjoehaines
force-pushed
the
retry-electron-perf-test
branch
from
5154c86 to
e36f1ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
As this runs on GH Actions, it's inherently unreliable as we could be given a very over-provisioned VM so the performance is unpredictable
Until we can migrate to a more stable platform, we can only retry this test until it passes — there is some value in knowing it will pass when retried, rather than always failing
I'd like to avoid increasing the allowed time any further — 150ms is already a lot and is just a compromise to allow the test to pass on CI (locally this test runs significantly quicker)