Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Maze.check for test assertions #1627

Merged
merged 8 commits into from
Dec 23, 2021
Merged

Use Maze.check for test assertions #1627

merged 8 commits into from
Dec 23, 2021

Conversation

twometresteve
Copy link
Contributor

Goal

Use the new Maze.check mechanism for making test assertions, avoiding potential problems from using functions in the global namespace.

Testing

Covered by a [quick ci] run.

@github-actions
Copy link

github-actions bot commented Dec 21, 2021 •
edited
Loading

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 41.58 kB 12.80 kB
After 41.58 kB 12.80 kB
± No change No change

code coverage diff

Coverage values did not change👌.

Total:

Lines Branches Functions Statements
0%(+0%) 0%(+0%) 0%(+0%) 0%(+0%)

Generated by 🚫 dangerJS against 233d842

fractalwrench
fractalwrench approved these changes Dec 23, 2021
View reviewed changes
Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twometresteve twometresteve merged commit 7e64cd9 into next Dec 23, 2021
@twometresteve twometresteve deleted the tms/use-maze-check branch December 23, 2021 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fractalwrench fractalwrench fractalwrench approved these changes

@nickdowell nickdowell Awaiting requested review from nickdowell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twometresteve @fractalwrench