Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(plugin-react-native-global-error-handler, plugin-react-native-session): convert tests #1059

Merged
merged 2 commits into from
Sep 28, 2020

Conversation

djskinner
Copy link
Contributor

Goal

Conversion of tests from jasmine to jest and TypeScript for consistency and performance and improved type checking.

Design

See previous discussions

Changeset

Converted plugin-react-native-global-error-handler, and plugin-react-native-session tests from jasmine to jest.

Testing

Automated tests pass. Changes to test files, internal types and configuration only.

@bugsnagbot
Copy link
Collaborator

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 39.62 kB 12.23 kB
After 39.62 kB 12.23 kB
± No change No change

Generated by 🚫 dangerJS against 83c0735

Base automatically changed from convert-tests-to-jest-2 to next September 28, 2020 13:31
@djskinner djskinner marked this pull request as ready for review September 28, 2020 13:31
@djskinner djskinner requested a review from a team as a code owner September 28, 2020 13:31
@djskinner djskinner merged commit 07ed735 into next Sep 28, 2020
@djskinner djskinner deleted the convert-tests-to-jest-3 branch September 28, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants