Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
This reduces memory consumption by removing the in-memory copy of breadcrumbs.
Design
Breadcrumbs are now loaded from disk whenever access is required.
As a side-effect this removes the possibility of crashes due to multithreaded access to breadcrumbs.
Testing
This behaviour is covered by unit tests (which required some modifications) and E2E test.
Verified that crash reports in the dashboard still contain the expected breadcrumbs.
Verified that breadcrumb modifications in an
OnSendErrorBlock
still alter what is sent to the dashboard.