feat: redacted keys' comparison is now case-insensitive #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmacharg
force-pushed
the
v6-redacted-keys-comparison-case-insensitive
branch
from
f7c1eaa
to
994dabd
Compare
fractalwrench
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Comparison of redacted keys should be case insensitive for strings.
Design
Comparison of key with redacted keys is now lower-cased. Keys and redacted keys remain as they were set. One side-effect is that a single redaction key can redact multiple pieces of metadata (e.g. "Password", "password" and "PASSWORD").
Changeset
Lowercasing added to
BugsnagEvent.isRedactedKey()Tests
A single unit test.