Move endpoint configuration to class #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
v6-endpoints
branch
from
30418a0
to
89cae7b
Compare
fractalwrench
force-pushed
the
v6-endpoints
branch
3 times, most recently
from
14adf5f
to
01d1c59
Compare
robinmacharg
suggested changes
Apr 17, 2020
robinmacharg
approved these changes
Apr 17, 2020
fractalwrench
force-pushed
the
v6-endpoints
branch
3 times, most recently
from
f1ae0e9
to
1fc7a38
Compare
fractalwrench
force-pushed
the
v6-endpoints
branch
from
1fc7a38
to
5a14d4c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Moves the configuration of the notify + sessions endpoint to a class, to match the notifier spec.
Changeset
Altered the
setEndpointsmethod into a public property of typeBugsnagEndpointConfiguration. Updated existing test coverage to use new syntax.