Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix)NSWorkspace-specific state change notifications now use the corr… #525

Conversation

robinmacharg
Copy link
Contributor

Goal

MacOS was incorrectly listening to a couple of automatic breadcrumb notifications on the default notification center. This PR corrects that.

Design

Extract the notifications in question and (within protective MacOS #if guards) add them to the correct NSWorkspace notification center.

Changeset

BugsnagClient.

Tests

Manual testing only. Additional methods whitelisted in mirror tests.

Review

Outstanding Questions

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review
  • The correct target branch has been selected (master for fixes, next for
    features)
  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

…ect notification center

Also tidied up some unnecessary #if logic fall-through occurrances.
@robinmacharg robinmacharg force-pushed the Change-NSWorkspace-notifications-to-use-NSWorkspace-specific-notification-center branch from b13744a to 2baf0f2 Compare April 3, 2020 09:32
@robinmacharg robinmacharg marked this pull request as ready for review April 3, 2020 09:32
@robinmacharg robinmacharg merged commit 2984c63 into v6 Apr 3, 2020
@robinmacharg robinmacharg deleted the Change-NSWorkspace-notifications-to-use-NSWorkspace-specific-notification-center branch April 3, 2020 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants