Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused APIs from BugsnagBreadcrumb interface #502

Merged
merged 3 commits into from
Mar 27, 2020

Conversation

fractalwrench
Copy link
Contributor

Goal

Removes/hides unused APIs from the BugsnagBreadcrumb interface. These are either no longer required or were originally part of the internal implementation and mistakenly included in the public header.

Additionally, the BugsnagBreadcrumbs interface has been moved into a separate non-public source file.

Changeset

The following APIs have been removed/hidden using a class extension:

+ (instancetype _Nullable)breadcrumbWithBlock:
    (BSGBreadcrumbConfiguration _Nonnull)block;
+ (instancetype _Nullable)breadcrumbFromDict:(NSDictionary *_Nonnull)dict;

The BugsnagBreadcrumbs class which contains the state of all the breadcrumbs in the application has been moved to a separate non-public source file.

Tests

Relied on existing test coverage

@fractalwrench fractalwrench merged commit 8872d7d into v6 Mar 27, 2020
@fractalwrench fractalwrench deleted the v6-breadcrumb-api branch March 27, 2020 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants