Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused APIs from BugsnagConfiguration interface #496

Merged
merged 5 commits into from
Mar 27, 2020
Merged

Remove unused APIs from BugsnagConfiguration interface #496

merged 5 commits into from
Mar 27, 2020

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Mar 25, 2020 •
edited
Loading

Goal

Removes/hides unused APIs from the BugsnagConfiguration interface. These are either no longer required or were originally part of the internal implementation and mistakenly included in the public header.

Changeset

The following APIs have been removed/hidden using a class extension:

BugsnagBeforeNotifyHook
BugsnagMetadata and BugsnagConfig
breadcrumbs
reportBackgroundOOMs
notifyURL and sessionURL
shouldAutoCaptureSessions
autoNotify
shouldSendReports
errorApiHeaders
sessionApiHeaders

Tests

Relied on existing test coverage

tomlongridge
tomlongridge approved these changes Mar 26, 2020
View reviewed changes
Source/BugsnagConfiguration.m Outdated Show resolved Hide resolved
@fractalwrench fractalwrench merged commit 3a0945e into v6 Mar 27, 2020
@fractalwrench fractalwrench deleted the v6-remove-config-apis branch March 27, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fractalwrench @tomlongridge