-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) Increased detail in handled event breadcrumb #493
Merged
robinmacharg
merged 10 commits into
v6
from
robin/add-additional-metadata-to-error-breadcrumbs
Mar 30, 2020
Merged
(feat) Increased detail in handled event breadcrumb #493
robinmacharg
merged 10 commits into
v6
from
robin/add-additional-metadata-to-error-breadcrumbs
Mar 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinmacharg
force-pushed
the
robin/add-additional-metadata-to-error-breadcrumbs
branch
from
March 23, 2020 13:56
2460a1d
to
41a9e0f
Compare
tomlongridge
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two very minor comments
Co-Authored-By: Tom Longridge <[email protected]>
Co-Authored-By: Tom Longridge <[email protected]>
…nge' into robin/add-additional-metadata-to-error-breadcrumbs # Conflicts: # Source/BugsnagClient.m
…mbs to fail to be reported A global search-and-replace of "name" by "message" in the breadcrumb portions of code (to bring the cocoa notifier in line with other notifiers) failed to take account of the Bugsnag error reporting API, which expects a "name"-keyed field.
…al-metadata-to-error-breadcrumbs
…tadata-to-error-breadcrumbs
robinmacharg
deleted the
robin/add-additional-metadata-to-error-breadcrumbs
branch
March 30, 2020 09:43
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Add additional metadata to handled error breadcrumbs.
Design
Simply add two additional fields to the preexisting breadcrumb metadata .
Changeset
BugsnagClient
. Some small additional formatting/renaming changes were incorporated.Tests
Unit test added.
Review
Outstanding Questions
master
for fixes,next
forfeatures)