refactor: rename Bugsnag.addAttribute to addMetadata, add tests #454
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Simple rename of
Bugsnag.addAttribute
toBugsnag.addMetadata
to add consistency across notifier platforms.Design
Simple search and replace. Unit tests were missing so have been added. Swift name differs from default translation so has been provided via NS_SWIFT_NAME.
The change was only applied at the top level. A separate change will be required at the Configuration level.
Changeset
Tests
Added ObjC unit tests and a Swift UT to check Swift name exposure.
Review
Outstanding Questions
master
for fixes,next
forfeatures)