Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setting to disable OOM reporting #345

Merged
merged 1 commit into from
May 9, 2019

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented May 8, 2019

Disables background OOM reporting by default

Changeset

  • Added BugsnagConfiguration.reportOOMs config option for disabling out-of-memory event reporting entirely.
  • Set BugsnagConfiguration.reportBackgroundOOMs to false by default as its noisy

Tests

  • Added new scenarios for the various permutations of OOM config options

Review

  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

Copy link
Contributor

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with the implementation. It'd be good to target next as this is a feature and not a hot-fix, also we'll need to alter our docs repo.

I'm concerned that the mazerunner scenarios could slow down our CI job, and think it'd be good to check whether there's any faster way of verifying the behaviour before merging.

Disables background OOM reporting by default
@kattrali kattrali force-pushed the kattrali/disable-oom-settings branch from c595088 to cee31cf Compare May 8, 2019 10:24
@kattrali kattrali merged commit 7a8c5c6 into master May 9, 2019
@kattrali kattrali deleted the kattrali/disable-oom-settings branch May 9, 2019 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants