Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect appVersion override when serialising KSCrash report #292

Merged
merged 3 commits into from
Jul 9, 2018

Conversation

fractalwrench
Copy link
Contributor

@fractalwrench fractalwrench commented Jul 6, 2018

Goal

Altering the appVersion via config.appVersion writes it into user_atcrash.config.appVersion in the KSCrash report. This is then translated into user.config.appVersion when read from disk. However, BugsnagCrashReport does not read this value when constructing JSON, meaning the wrong value is serialised.

Changeset

Altered the app metadata parsing methods to take the full report, and use user.config.appVersion if the value is set.

Tests

Added a test for the default app version state, and an override. Also manually tested both scenarios.

Review

For the submitter, initial self-review:

  • Commented on code changes inline explain the reasoning behind the approach
  • Reviewed the test cases added for completeness and possible points for discussion
  • A changelog entry was added for the goal of this pull request
  • Check the scope of the changeset - is everything in the diff required for the pull request?
  • This pull request is ready for:
    • Initial review of the intended approach, not yet feature complete
    • Structural review of the classes, functions, and properties modified
    • Final review

For the pull request reviewer(s), this changeset has been reviewed for:

  • Consistency across platforms for structures or concepts added or modified
  • Consistency between the changeset and the goal stated above
  • Internal consistency with the rest of the library - is there any overlap between existing interfaces and any which have been added?
  • Usage friction - is the proposed change in usage cumbersome or complicated?
  • Performance and complexity - are there any cases of unexpected O(n^3) when iterating, recursing, flat mapping, etc?
  • Concurrency concerns - if components are accessed asynchronously, what issues will arise
  • Thoroughness of added tests and any missing edge cases
  • Idiomatic use of the language

altering the appVersion via the config writes it into 'user_atcrash.config.appVersion' in the
kscrash report, which is translated to 'user.config.appVersion' when read from disk. This value was
not correctly read when constructing json.
@fractalwrench fractalwrench requested a review from a team July 6, 2018 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants