Respect appVersion override when serialising KSCrash report #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Altering the appVersion via
config.appVersion
writes it intouser_atcrash.config.appVersion
in the KSCrash report. This is then translated intouser.config.appVersion
when read from disk. However,BugsnagCrashReport
does not read this value when constructing JSON, meaning the wrong value is serialised.Changeset
Altered the app metadata parsing methods to take the full report, and use
user.config.appVersion
if the value is set.Tests
Added a test for the default app version state, and an override. Also manually tested both scenarios.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: