Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAT-8949] Disable OOM detection for Mac Catalyst apps #1489

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Prevent erroneous OOMs from being reported for Mac Catalyst apps.

Speaking of memory, the Mac memory model applies which means there are no enforced memory limits.

Changeset

Disables OOM detection when targeting Mac Catalyst.

Testing

Modified the example app's OutOfMemoryController to attempt to force an OOM to occur, but even after filling over 100 GB of memory with random data (to thwart the memory compressor) I was unable to reproduce one, confirming the statement made in the WWDC video.

@github-actions
Copy link

Bugsnag.framework binary size did not change - 706,688 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 1cededc into next Oct 3, 2022
@nickdowell nickdowell deleted the nickdowell/mac-catalyst-disable-ooms branch October 3, 2022 08:43
@nickdowell nickdowell mentioned this pull request Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants