-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Plat-8841] feature flags order #1481
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
kstenerud
force-pushed
the
PLAT-8841-feature-flags-order
branch
4 times, most recently
from
September 14, 2022 07:37
f45d05b
to
e9d7c0e
Compare
nickdowell
suggested changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks sound but currently too much is exposed in BugsnagInternals.h
and I'm hoping BSG_OBJC_DIRECT_MEMBERS
will help reduce the bloat (currently +3.4K 🙁)
kstenerud
force-pushed
the
PLAT-8841-feature-flags-order
branch
5 times, most recently
from
September 14, 2022 09:11
7d655d6
to
9664d2c
Compare
kstenerud
force-pushed
the
PLAT-8841-feature-flags-order
branch
from
September 14, 2022 09:25
9664d2c
to
2cb1a9c
Compare
nickdowell
approved these changes
Sep 14, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
PLAT-8841: Keep ordering of feature flags, and improve performance of the feature flags store
Design
Replaced the array based feature flags store with a combined array and dictionary in order to speed up access.
Each dictionary entry maps to an index in the backing array, which contains the feature flag. Removing a feature flag leaves a hole in the array in order to avoid compaction costs. A forced compaction occurs only if there are more than 1000 holes.
The measured performance difference between this and a straight-up unordered dictionary is negligible (I've put in performance tests for easy comparison).
Testing
Updated tests to match the new expected feature flag ordering, and added some performance tests.