Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid sessions in BareboneTestUnhandledErrorScenario #1408

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Ignore invalid sessions in BareboneTestUnhandledErrorScenario #1408

merged 1 commit into from
Jun 21, 2022

Conversation

nickdowell
Copy link
Contributor

Goal

Fix flake in barebone_tests.feature:123 that can occur if crash occurs in the middle of session HTTP request.

Changeset

Ignores invalid session requests for this scenario.

Testing

Verified on CI

@github-actions
Copy link

Bugsnag.framework binary size did not change - 814,440 bytes

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Generated by 🚫 Danger

@nickdowell nickdowell merged commit 3ca03e3 into next Jun 21, 2022
@nickdowell nickdowell deleted the nickdowell/fix-e2e-flakes branch June 21, 2022 09:13
This was referenced Jun 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twometresteve twometresteve twometresteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickdowell @twometresteve