-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAT-8545] Capture the current thread name on crash #1406
Conversation
Generated by 🚫 Danger |
6c65bf2
to
ae3a3d8
Compare
de7296e
to
6398f26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes to bsg_kscrw_i_writeThread
LGTM but I think adding more scenarios to the E2E is a bad idea due to additional run time required. Instead the thread name checks can be conditionalised - e.g.
And on iOS 13 and later, the event "threads.0.name" equals "потік"
6398f26
to
c307386
Compare
Goal
Capturing thread names is async-safe when getting the current thread name. This can be useful when recording Objective-C and C++ exceptions because they are handled on the same thread that threw the exception.
Note: This won't capture the offending thread name for mach exceptions because they are handled on the mach exception handler thread.
Testing
Added thread name checks for ObjC and C++ exception e2e tests.